This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Query: Add product visibility query support #7951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
added
status: needs review
type: bug
|
The release ZIP for this PR is accessible via: |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
TypeScript Errors ReportFiles with errors: 431 🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.01 MB ℹ️ View Unchanged
|
|
I'm fixing the failing unit test. We need to update the test to include product visibility query. |
sunyatasattva
approved these changes
Dec 19, 2022
Comment on lines
+331
to
+333
| if ( ! is_array( $stock_statii ) ) { | ||
| return array(); | ||
| } |
There was a problem hiding this comment.
Not a big deal, but should we return even earlier? We don't even need a call to wc_get_product_stock_status_option if the argument is not an array.
Comment on lines
+335
to
+338
| /** | ||
| * If all available stock status are selected, we don't need to add the | ||
| * meta query for stock status. | ||
| */ |
There was a problem hiding this comment.
Thanks for this comments! ❤️
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
alexflorisca
added
type: enhancement
Closed
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7746, replaces #7748
This PR adds product visibility support to the Product Query block:
outofstockis selected, we return an empty stock query and includeoutofstockterm to product visibility query.By using a more complex logic, we can archive the clear UI by selecting all available stock statuses by default, see #7748 (comment).
Testing
Automated Tests
User Facing Testing
Producs (Beta)block and[recent_products]shortcode block.Producs (Beta)to 4 products per row x 3 rows.Newest.Producs (Beta)block (the front end and the editor) and the Recent Products shortcode are the same.WooCommerce Visibility
Changelog